Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding support to fetch WATER WASM files #628

Merged
merged 16 commits into from
Oct 22, 2024
Merged

adding support to fetch WATER WASM files #628

merged 16 commits into from
Oct 22, 2024

Conversation

WendelHime
Copy link
Contributor

@WendelHime WendelHime commented Oct 8, 2024 •
edited
Loading

This pull request add support to downloading WASM files from provided configuration. Currently at http-proxy we're only supporting HTTPS URLs.

@WendelHime WendelHime marked this pull request as ready for review October 9, 2024 22:48
@WendelHime WendelHime requested review from hwh33 and garmr-ulfr October 9, 2024 22:48
garmr-ulfr
garmr-ulfr reviewed Oct 10, 2024
View reviewed changes
http_proxy.go Outdated Show resolved Hide resolved
water/downloader.go Outdated Show resolved Hide resolved
water/downloader.go Show resolved Hide resolved
hwh33
hwh33 reviewed Oct 11, 2024
View reviewed changes
water/downloader.go Outdated Show resolved Hide resolved
water/mock_downloader.go Outdated Show resolved Hide resolved
@WendelHime
Copy link
Contributor Author

All suggestions adopted! This is ready for review again!

garmr-ulfr
garmr-ulfr approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@garmr-ulfr garmr-ulfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

hwh33
hwh33 approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@hwh33 hwh33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (just one small piece of unused code)! Awesome work =)

http_proxy.go Outdated Show resolved Hide resolved
@WendelHime WendelHime merged commit 9a68fb2 into main Oct 22, 2024
1 check passed
@WendelHime WendelHime deleted the feat/adding-water-uris branch October 22, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garmr-ulfr garmr-ulfr garmr-ulfr approved these changes

@hwh33 hwh33 hwh33 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WendelHime @hwh33 @garmr-ulfr